From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: cpuid: mask more bits in leaf 0xd and subleaves
Date: Wed, 03 Dec 2014 13:10:28 +0100
Message-ID: <547EFDB4.5060709@redhat.com>
References: <1417525770-16485-1-git-send-email-pbonzini@redhat.com> <20141202230536.GA12980@potion.redhat.com> <547EC40E.5010506@redhat.com> <20141203120739.GA26617@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Wanpeng Li <wanpeng.li@linux.intel.com>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20141203120739.GA26617@potion.brq.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 03/12/2014 13:07, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>> > Well, there is a WARN just above. :)  But I can change it to zero =
instead.
> Yeah, I wasn't sure about the WARN ... I can only see it trigger afte=
r
> host xcr0 changes and we are much more screwed in that case anyway :)
> (But it has a chance of catching a bug, so it isn't only bad.)
>=20
> The guest expects 0 here, so I'd rather have it ...

Ok, I'll have

		if (WARN_ON_ONCE(entry[i].ecx & 1))
			continue;
	}
	entry[i].ecx =3D 0;
	entry[i].edx =3D 0;
	...

Thanks for the review!

Paolo