From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [CFT PATCH v2 2/2] KVM: x86: support XSAVES usage in the host
Date: Wed, 03 Dec 2014 15:26:12 +0100
Message-ID: <547F1D84.9040505@redhat.com>
References: <1416847414-22253-1-git-send-email-pbonzini@redhat.com> <1416847414-22253-3-git-send-email-pbonzini@redhat.com> <802AF3F4-2631-4979-A8CC-46B406546062@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kvm list <kvm@vger.kernel.org>,
	Wanpeng Li <wanpeng.li@linux.intel.com>,
	Nadav Amit <namit@cs.technion.ac.il>, hpa@linux.intel.com,
	Fenghua Yu <fenghua.yu@intel.com>
To: Nadav Amit <nadav.amit@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <802AF3F4-2631-4979-A8CC-46B406546062@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 03/12/2014 15:23, Nadav Amit wrote:
> I think it is better just to replace the last line with:
> 
> *(u64 *)(dest + XSAVE_HDR_OFFSET) = xsave->xsave_hdr.xstate_bv

Right, this matches

        u64 xstate_bv = *(u64 *)(src + XSAVE_HDR_OFFSET);
	...
        xsave->xsave_hdr.xstate_bv = xstate_bv;

in load_xsave.

Paolo