From: Jan Kiszka <jan.kiszka@web.de>
To: Wincy Van <fanwenyi0529@gmail.com>
Cc: Bandan Das <bsd@redhat.com>,
Eugene Korenevsky <ekorenevsky@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH RFC] KVM: x86: nested: support for MSR loading/storing
Date: Mon, 08 Dec 2014 08:07:25 +0100 [thread overview]
Message-ID: <54854E2D.2010900@web.de> (raw)
In-Reply-To: <CACzj_yV6JnFP=Y8o=rtFGY6MZgqBg9sYbPm14SEkFgzB7-PWDA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On 2014-12-08 04:49, Wincy Van wrote:
>>>> +static bool vmx_msr_switch_area_verify(u32 count, u64 addr, int maxphyaddr)
>>>> +{
>>>> + if (count == 0)
>>>> + return true;
>>>> + if ((addr & 0xf) != 0)
>>
>> Bits 11:0 have to be zero, in fact (page alignment required).
>
>
> Why? According to SDM(24.8.2), "If the VM-entry MSR-load count is not zero,
> the address must be 16-byte aligned."
True, sorry, confused with the MSR usage bitmap.
>
> I think the macro IS_ALIGNED would be better.
Yes.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-12-08 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 22:57 [PATCH RFC] KVM: x86: nested: support for MSR loading/storing Eugene Korenevsky
2014-12-07 9:46 ` Bandan Das
2014-12-07 10:21 ` Jan Kiszka
[not found] ` <CACzj_yWP0QBHK+n3QdyLdg-JEU9DrUzPC-ahSyLUGRW=JrtvNQ@mail.gmail.com>
[not found] ` <CACzj_yU+xCY3bHVPh-SQ0y-M+NEoUYEAzH=XLgza3hMGw1V6wg@mail.gmail.com>
2014-12-08 3:49 ` Wincy Van
2014-12-08 7:07 ` Jan Kiszka [this message]
2014-12-09 0:37 ` Eugene Korenevsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54854E2D.2010900@web.de \
--to=jan.kiszka@web.de \
--cc=bsd@redhat.com \
--cc=ekorenevsky@gmail.com \
--cc=fanwenyi0529@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox