From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Remove prefix flag when GP macro is used
Date: Wed, 10 Dec 2014 12:51:19 +0100 [thread overview]
Message-ID: <548833B7.2050002@redhat.com> (raw)
In-Reply-To: <1417945782-18041-1-git-send-email-namit@cs.technion.ac.il>
On 07/12/2014 10:49, Nadav Amit wrote:
> The macro GP already sets the flag Prefix. Remove the redundant flag for
> 0f_38_f0 and 0f_38_f1 opcodes.
>
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
> arch/x86/kvm/emulate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 3817334..b4f4201 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -4172,8 +4172,8 @@ static const struct opcode opcode_map_0f_38[256] = {
> /* 0x80 - 0xef */
> X16(N), X16(N), X16(N), X16(N), X16(N), X16(N), X16(N),
> /* 0xf0 - 0xf1 */
> - GP(EmulateOnUD | ModRM | Prefix, &three_byte_0f_38_f0),
> - GP(EmulateOnUD | ModRM | Prefix, &three_byte_0f_38_f1),
> + GP(EmulateOnUD | ModRM, &three_byte_0f_38_f0),
> + GP(EmulateOnUD | ModRM, &three_byte_0f_38_f1),
> /* 0xf2 - 0xff */
> N, N, X4(N), X8(N)
> };
>
Applied, thanks.
Paolo
prev parent reply other threads:[~2014-12-10 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 9:49 [PATCH] KVM: x86: Remove prefix flag when GP macro is used Nadav Amit
2014-12-10 11:51 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548833B7.2050002@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox