From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: Remove prefix flag when GP macro is used Date: Wed, 10 Dec 2014 12:51:19 +0100 Message-ID: <548833B7.2050002@redhat.com> References: <1417945782-18041-1-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34255 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754790AbaLJLv3 (ORCPT ); Wed, 10 Dec 2014 06:51:29 -0500 In-Reply-To: <1417945782-18041-1-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 07/12/2014 10:49, Nadav Amit wrote: > The macro GP already sets the flag Prefix. Remove the redundant flag for > 0f_38_f0 and 0f_38_f1 opcodes. > > Signed-off-by: Nadav Amit > --- > arch/x86/kvm/emulate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 3817334..b4f4201 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4172,8 +4172,8 @@ static const struct opcode opcode_map_0f_38[256] = { > /* 0x80 - 0xef */ > X16(N), X16(N), X16(N), X16(N), X16(N), X16(N), X16(N), > /* 0xf0 - 0xf1 */ > - GP(EmulateOnUD | ModRM | Prefix, &three_byte_0f_38_f0), > - GP(EmulateOnUD | ModRM | Prefix, &three_byte_0f_38_f1), > + GP(EmulateOnUD | ModRM, &three_byte_0f_38_f0), > + GP(EmulateOnUD | ModRM, &three_byte_0f_38_f1), > /* 0xf2 - 0xff */ > N, N, X4(N), X8(N) > }; > Applied, thanks. Paolo