From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [PATCH] kvm: coalesced_mmio: remove one redundant check inside of coalesced_mmio_in_range() Date: Fri, 12 Dec 2014 09:24:38 +0800 Message-ID: <548A43D6.2020507@intel.com> References: <1418266961-27277-1-git-send-email-tiejun.chen@intel.com> <54897FFD.5030806@redhat.com> <548A3E8E.7080609@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mga02.intel.com ([134.134.136.20]:18544 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755339AbaLLBYk (ORCPT ); Thu, 11 Dec 2014 20:24:40 -0500 In-Reply-To: <548A3E8E.7080609@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2014/12/12 9:02, Chen, Tiejun wrote: > On 2014/12/11 19:29, Paolo Bonzini wrote: >> >> >> On 11/12/2014 04:02, Tiejun Chen wrote: >>> We already check 'len' above to make sure it already isn't >>> negative here, so indeed, (addr + len < addr) should never be happened. >> >> ... except if there is an overflow. > I think now I can understand what you mean. Thanks Tiejun