From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: nVMX MSR load/store feature
Date: Sun, 14 Dec 2014 10:51:33 +0100
Message-ID: <548D5DA5.6000602@redhat.com>
References: <CAJC2YLa3bdQg4sJFuvX4NjSBT_q1hrx-q8W5kjc9gKBeE6ZwzA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Eugene Korenevsky <ekorenevsky@gmail.com>,
	Jan Kiszka <jan.kiszka@web.de>, Bandan Das <bsd@redhat.com>,
	kvm@vger.kernel.org,
	=?UTF-8?B?UmFkaW0gS3LEjQ==?= =?UTF-8?B?bcOhxZk=?=
	<rkrcmar@redhat.com>, Wanpeng Li <wanpeng.li@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wg0-f54.google.com ([74.125.82.54]:51801 "EHLO
	mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752939AbaLNJvh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 14 Dec 2014 04:51:37 -0500
Received: by mail-wg0-f54.google.com with SMTP id l2so12412261wgh.27
        for <kvm@vger.kernel.org>; Sun, 14 Dec 2014 01:51:36 -0800 (PST)
In-Reply-To: <CAJC2YLa3bdQg4sJFuvX4NjSBT_q1hrx-q8W5kjc9gKBeE6ZwzA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 14/12/2014 02:17, Eugene Korenevsky wrote:
> Hi there,
> 
> Please DO NOT take v3 version of patchset in account. It contains bug
> (missing check for MSR load/store area size in
> `nested_vmx_check_msr_switch`). This bug has been fixed in v4 version
> of patchset.
> 
> Now MSR load/store feature is partially covered with tests (see patch
> to kvm-unit-tests in kvm-devel list).
> Unfortunately the kvm-unit-tests framework cannot check for failed
> VM-entry, so I skipped tests for incorrectly set MSR load/store areas
> (16-byte alignment, address bits beyond address space etc). Maybe
> method `vmfail_handler` should be added to `struct vmx_test`. Anyway
> this can be done in the separate patch.

Thanks!

Paolo