From: Paolo Bonzini <pbonzini@redhat.com>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: "Jan Kiszka" <jan.kiszka@web.de>, "Bandan Das" <bsd@redhat.com>,
kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@linux.intel.com>
Subject: Re: nVMX MSR load/store feature
Date: Mon, 15 Dec 2014 15:08:20 +0100 [thread overview]
Message-ID: <548EEB54.9060105@redhat.com> (raw)
In-Reply-To: <CAJC2YLbkrbA4OmDpBeT3pJ0nk_tTWcnzhuEKQvY79WGAFH49PQ@mail.gmail.com>
On 15/12/2014 14:59, Eugene Korenevsky wrote:
>> The diff is just
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index d6fe958a0403..09ccf6c09435 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -8305,6 +8305,8 @@ static int nested_vmx_check_msr_switch(struct kvm_vcpu *vcpu,
>> WARN_ON(1);
>> return -EINVAL;
>> }
>> + if (count == 0)
>> + return 0;
>> if (!IS_ALIGNED(addr, 16) || addr >> maxphyaddr ||
>> (addr + count * sizeof(struct vmx_msr_entry) - 1) >> maxphyaddr) {
>> pr_warn_ratelimited(
>>
>> right?
>
> Yes. Without this check, `nested_vmx_check_msr_switch` returns -EINVAL
> for count==0 and addr==0.
Ok, thanks. I'll push the patches to kvm/queue as soon as my testing
finishes.
Paolo
prev parent reply other threads:[~2014-12-15 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 1:17 nVMX MSR load/store feature Eugene Korenevsky
2014-12-14 9:51 ` Paolo Bonzini
2014-12-15 12:10 ` Paolo Bonzini
2014-12-15 13:59 ` Eugene Korenevsky
2014-12-15 14:08 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548EEB54.9060105@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=ekorenevsky@gmail.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox