Re: [PATCH 02/10] x86: pmu: report takes a fmt

[Paolo Bonzini <pbonzini@redhat.com>]

On 12/12/2014 17:06, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  x86/pmu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/x86/pmu.c b/x86/pmu.c
> index 5c85146810cb1..f116bafebf424 100644
> --- a/x86/pmu.c
> +++ b/x86/pmu.c
> @@ -228,14 +228,12 @@ static void check_gp_counter(struct pmu_event *evt)
>  		.ctr = MSR_IA32_PERFCTR0,
>  		.config = EVNTSEL_OS | EVNTSEL_USR | evt->unit_sel,
>  	};
> -	char fmt[100];
>  	int i;
>  
>  	for (i = 0; i < num_counters; i++, cnt.ctr++) {
>  		cnt.count = 0;
>  		measure(&cnt, 1);
> -		snprintf(fmt, sizeof(fmt), "%s-%%d", evt->name);
> -		report(fmt, verify_event(cnt.count, evt), i);
> +		report("%s-%%d", verify_event(cnt.count, evt), evt->name, i);

Should be %s-%d, changed it.

Paolo

>  	}
>  }
>  
>