From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 02/10] x86: pmu: report takes a fmt Date: Mon, 15 Dec 2014 16:03:14 +0100 Message-ID: <548EF832.9090301@redhat.com> References: <1418400377-17388-1-git-send-email-drjones@redhat.com> <1418400377-17388-3-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from plane.gmane.org ([80.91.229.3]:52511 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753918AbaLOPDm (ORCPT ); Mon, 15 Dec 2014 10:03:42 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Y0XBP-0007GQ-My for kvm@vger.kernel.org; Mon, 15 Dec 2014 16:03:35 +0100 Received: from net-2-35-193-40.cust.vodafonedsl.it ([2.35.193.40]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Dec 2014 16:03:35 +0100 Received: from pbonzini by net-2-35-193-40.cust.vodafonedsl.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Dec 2014 16:03:35 +0100 In-Reply-To: <1418400377-17388-3-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/12/2014 17:06, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > x86/pmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/x86/pmu.c b/x86/pmu.c > index 5c85146810cb1..f116bafebf424 100644 > --- a/x86/pmu.c > +++ b/x86/pmu.c > @@ -228,14 +228,12 @@ static void check_gp_counter(struct pmu_event *evt) > .ctr = MSR_IA32_PERFCTR0, > .config = EVNTSEL_OS | EVNTSEL_USR | evt->unit_sel, > }; > - char fmt[100]; > int i; > > for (i = 0; i < num_counters; i++, cnt.ctr++) { > cnt.count = 0; > measure(&cnt, 1); > - snprintf(fmt, sizeof(fmt), "%s-%%d", evt->name); > - report(fmt, verify_event(cnt.count, evt), i); > + report("%s-%%d", verify_event(cnt.count, evt), evt->name, i); Should be %s-%d, changed it. Paolo > } > } > >