From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 02/10] x86: pmu: report takes a fmt
Date: Mon, 15 Dec 2014 16:03:19 +0100 [thread overview]
Message-ID: <548EF837.5050908@redhat.com> (raw)
In-Reply-To: <1418400377-17388-3-git-send-email-drjones@redhat.com>
On 12/12/2014 17:06, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> x86/pmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/x86/pmu.c b/x86/pmu.c
> index 5c85146810cb1..f116bafebf424 100644
> --- a/x86/pmu.c
> +++ b/x86/pmu.c
> @@ -228,14 +228,12 @@ static void check_gp_counter(struct pmu_event *evt)
> .ctr = MSR_IA32_PERFCTR0,
> .config = EVNTSEL_OS | EVNTSEL_USR | evt->unit_sel,
> };
> - char fmt[100];
> int i;
>
> for (i = 0; i < num_counters; i++, cnt.ctr++) {
> cnt.count = 0;
> measure(&cnt, 1);
> - snprintf(fmt, sizeof(fmt), "%s-%%d", evt->name);
> - report(fmt, verify_event(cnt.count, evt), i);
> + report("%s-%%d", verify_event(cnt.count, evt), evt->name, i);
Should be %s-%d, changed it.
Paolo
> }
> }
>
>
next prev parent reply other threads:[~2014-12-15 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 16:06 [PATCH kvm-unit-tests 00/10] report is nice, use it more Andrew Jones
2014-12-12 16:06 ` [PATCH 01/10] x86: hypercall: add missing report_summary Andrew Jones
2014-12-12 16:06 ` [PATCH 02/10] x86: pmu: report takes a fmt Andrew Jones
2014-12-15 15:03 ` Paolo Bonzini
2014-12-15 15:03 ` Paolo Bonzini [this message]
2014-12-12 16:06 ` [PATCH 03/10] x86: vmx: better use of report Andrew Jones
2014-12-12 16:06 ` [PATCH 04/10] x86: tsc_adjust: use report Andrew Jones
2014-12-12 16:06 ` [PATCH 05/10] x86: svm: " Andrew Jones
2014-12-12 16:06 ` [PATCH 06/10] x86: asyncpf: " Andrew Jones
2014-12-12 16:06 ` [PATCH 07/10] x86: xsave: " Andrew Jones
2014-12-12 16:06 ` [PATCH 08/10] report: add prefix support Andrew Jones
2014-12-12 16:06 ` [PATCH 09/10] x86: use report prefixes Andrew Jones
2014-12-12 16:06 ` [PATCH 10/10] arm: " Andrew Jones
2014-12-12 16:19 ` [PATCH kvm-unit-tests 00/10] report is nice, use it more Andrew Jones
2014-12-15 15:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548EF837.5050908@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox