From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [patch 2/3] KVM: x86: add option to advance tscdeadline hrtimer
 expiration
Date: Tue, 16 Dec 2014 16:18:16 +0100
Message-ID: <54904D38.4080400@redhat.com>
References: <20141215220605.806000829@redhat.com> <20141215220916.959811227@redhat.com> <549042EE.8090205@redhat.com> <20141216151355.GC32479@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Luiz Capitulino <lcapitulino@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Radim Krcmar <rkrcmar@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57925 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750817AbaLPPSY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 16 Dec 2014 10:18:24 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBGFIM0H010708
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)
	for <kvm@vger.kernel.org>; Tue, 16 Dec 2014 10:18:23 -0500
In-Reply-To: <20141216151355.GC32479@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 16/12/2014 16:13, Marcelo Tosatti wrote:
>> > So perhaps you can get rid of patch 1 and check
>> > kvm_apic_vid_enabled(vcpu->kvm):
>> > 
>> > 	if (k_a_v_e(vcpu->kvm)
>> > 		return true;
>> > 	if (apic_test_vector(vec, apic->regs + APIC_ISR))
>> > 		return true;
>> > 
>> > Does this sound correct?
> * expired_tscdeadline != 0.
> * APIC timer interrupt delivery masked at LVTT register.
> 
> Implies expired_tscdeadline != 0 and interrupt not injected.

Good point.

Paolo