public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Smarduch <m.smarduch@samsung.com>
To: "christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Clarification for patch 7
Date: Tue, 16 Dec 2014 19:40:09 -0800	[thread overview]
Message-ID: <5490FB19.5050406@samsung.com> (raw)

Hi Christoffer, Marc -
   in stage2_dissolve_pmd() CONFIG_SMP is
unnecessary. At the time huge page is write protected,
until it faults and is cleared any page in the range
may be dirty not just the gpa access that caused the
fault.

The comment on another CPU is wrong, I
confused myself while testing it should not be possible for
another CPU to write to same PMD range while
another is handling its PMD fault. I ran a test with
only initrd which exposed an issue using my
test scenario, QEMU appears fine.

It also depends on user space if you first turn
on logging, do pre-copy then marking just the page
is enough. It's hard to interpret the API in this
case. It just says dirty pages since the last
call.

That patch could be resent without upsetting
the rest.

- Mario

             reply	other threads:[~2014-12-17  3:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  3:40 Mario Smarduch [this message]
2015-01-07 12:39 ` Clarification for patch 7 Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5490FB19.5050406@samsung.com \
    --to=m.smarduch@samsung.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox