From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v3 17/26] KVM: make kvm_set_msi_irq() public Date: Wed, 17 Dec 2014 18:32:20 +0100 Message-ID: <5491BE24.4040105@redhat.com> References: <1418397300-10870-1-git-send-email-feng.wu@intel.com> <1418397300-10870-18-git-send-email-feng.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , KVM list , Eric Auger To: "Wu, Feng" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Gleb Natapov , Paolo Bonzini , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , Alex Williamson Return-path: In-Reply-To: <1418397300-10870-18-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: kvm.vger.kernel.org On 12/12/2014 16:14, Feng Wu wrote: > Make kvm_set_msi_irq() public, we can use this function outside. > > Signed-off-by: Feng Wu > --- > include/linux/kvm_host.h | 2 ++ > virt/kvm/irq_comm.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index cfa85ac..5cd4420 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -785,6 +785,8 @@ void kvm_unregister_irq_ack_notifier(struct kvm *kvm, > struct kvm_irq_ack_notifier *kian); > int kvm_request_irq_source_id(struct kvm *kvm); > void kvm_free_irq_source_id(struct kvm *kvm, int irq_source_id); > +void kvm_set_msi_irq(struct kvm_kernel_irq_routing_entry *e, > + struct kvm_lapic_irq *irq); This function is now in arch/x86, so please add to arch/x86/include/asm/kvm_host.h instead. > #ifdef CONFIG_KVM_DEVICE_ASSIGNMENT > int kvm_iommu_map_pages(struct kvm *kvm, struct kvm_memory_slot *slot); > diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c > index f3c5d69..231671a 100644 > --- a/virt/kvm/irq_comm.c > +++ b/virt/kvm/irq_comm.c > @@ -106,7 +106,7 @@ int kvm_irq_delivery_to_apic(struct kvm *kvm, struct kvm_lapic *src, > return r; > } > > -static inline void kvm_set_msi_irq(struct kvm_kernel_irq_routing_entry *e, > +void kvm_set_msi_irq(struct kvm_kernel_irq_routing_entry *e, > struct kvm_lapic_irq *irq) > { > trace_kvm_msi_set_irq(e->msi.address_lo, e->msi.data); >