From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [patch 2/3] KVM: x86: add option to advance tscdeadline hrtimer expiration
Date: Tue, 23 Dec 2014 14:18:03 +0100 [thread overview]
Message-ID: <54996B8B.2090504@redhat.com> (raw)
In-Reply-To: <20141218122440.GA15896@amt.cnet>
On 18/12/2014 13:24, Marcelo Tosatti wrote:
> True. I can change to a direct wait if that is preferred.
What about this:
guest_tsc = kvm_x86_ops->read_l1_tsc(vcpu, native_read_tsc());
trace_kvm_wait_lapic_expire(vcpu->vcpu_id, guest_tsc - tsc_deadline);
/* We know that __delay is delay_tsc, see kvm_timer_init. */
if (guest_tsc < tsc_deadline)
__delay(tsc_deadline - guest_tsc);
and a check in kvm_timer_init:
if (check_tsc_unstable() && lapic_timer_advance_ns) {
pr_info("kvm: unstable TSC, disabling lapic_timer_advance_ns\n");
lapic_timer_advance_ns = 0;
}
Paolo
next prev parent reply other threads:[~2014-12-23 13:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:08 [patch 0/3] KVM: add option to advance tscdeadline hrtimer expiration (v5) Marcelo Tosatti
2014-12-16 14:08 ` [patch 1/3] KVM: x86: add method to test PIR bitmap vector Marcelo Tosatti
2014-12-17 14:45 ` Radim Krcmar
2014-12-16 14:08 ` [patch 2/3] KVM: x86: add option to advance tscdeadline hrtimer expiration Marcelo Tosatti
2014-12-17 14:58 ` Radim Krcmar
2014-12-17 17:41 ` Marcelo Tosatti
2014-12-17 17:48 ` Paolo Bonzini
2014-12-17 19:36 ` Radim Krcmar
2014-12-18 12:24 ` Marcelo Tosatti
2014-12-23 13:18 ` Paolo Bonzini [this message]
2014-12-16 14:08 ` [patch 3/3] KVM: x86: add tracepoint to wait_lapic_expire Marcelo Tosatti
2014-12-17 15:06 ` Radim Krcmar
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 20:58 [patch 0/3] KVM: add option to advance tscdeadline hrtimer expiration (v6) Marcelo Tosatti
2014-12-23 20:58 ` [patch 2/3] KVM: x86: add option to advance tscdeadline hrtimer expiration Marcelo Tosatti
2015-01-05 18:12 ` Radim Krcmar
2015-01-05 18:20 ` Radim Krcmar
2015-01-08 17:41 ` Marcelo Tosatti
2015-01-08 21:44 ` Paolo Bonzini
2014-12-15 22:06 [patch 0/3] KVM: add option to advance tscdeadline hrtimer expiration (v4) Marcelo Tosatti
2014-12-15 22:06 ` [patch 2/3] KVM: x86: add option to advance tscdeadline hrtimer expiration Marcelo Tosatti
2014-12-16 14:34 ` Paolo Bonzini
2014-12-16 15:13 ` Marcelo Tosatti
2014-12-16 15:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54996B8B.2090504@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox