From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
"Denis V. Lunev" <den-lists@parallels.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Tiejun Chen <tiejun.chen@intel.com>,
QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled()
Date: Sat, 27 Dec 2014 15:52:12 +0100 [thread overview]
Message-ID: <549EC79C.2090608@redhat.com> (raw)
In-Reply-To: <CAFEAcA_DTVFUE5QmU3T8DbuZQwhcXPhuxVfEYOTyST3sDL0-PQ@mail.gmail.com>
On 26/12/2014 18:59, Peter Maydell wrote:
> Mm, but once you're into such microoptimisations as this you really
> need to have a good justification for the effort, in the form of
> profiling measurements that indicate that this is a hot path.
> In this case that seems pretty unlikely, because I'd expect all
> the systems where we care about performance will support irqfds,
> so we won't be taking the early-exit code path anyhow. (And
> not supporting irqfds is leaving much more performance on the
> table than we could possibly be talking about in this function.)
Also, it's even possible for a compiler to figure this out. All in all,
I don't see any advantage to this patch...
Paolo
next prev parent reply other threads:[~2014-12-27 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 8:05 [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled() Tiejun Chen
2014-12-26 10:00 ` [Qemu-devel] " Peter Maydell
2014-12-26 10:16 ` Denis V. Lunev
2014-12-26 17:59 ` [Qemu-devel] " Peter Maydell
2014-12-27 14:52 ` Paolo Bonzini [this message]
2014-12-29 1:31 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549EC79C.2090608@redhat.com \
--to=pbonzini@redhat.com \
--cc=den-lists@parallels.com \
--cc=kvm@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tiejun.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox