From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/8] KVM: x86: Emulator fixes
Date: Thu, 08 Jan 2015 11:42:34 +0100 [thread overview]
Message-ID: <54AE5F1A.2030204@redhat.com> (raw)
In-Reply-To: <1419468743-23732-1-git-send-email-namit@cs.technion.ac.il>
On 25/12/2014 01:52, Nadav Amit wrote:
> Few more emulator fixes. Each is logically independent from the others.
>
> The first one is the most interesting one. It appears that the current
> behavior may cause the VM to enter the page-fault handler twice on certain
> faulting write accesses. If you do not like my solution, please propose a
> better one.
>
> The fourth (JMP/CALL using call- or task-gate) is not a fix, but returns an
> error instead of emulating the wrong (#GP) exception.
>
> Thanks for reviewing the patches.
>
> Nadav Amit (8):
> KVM: x86: #PF error-code on R/W operations is wrong
> KVM: x86: pop sreg accesses only 2 bytes
> KVM: x86: fnstcw and fnstsw may cause spurious exception
> KVM: x86: JMP/CALL using call- or task-gate causes exception
> KVM: x86: em_call_far should return failure result
> KVM: x86: POP [ESP] is not emulated correctly
> KVM: x86: Do not set access bit on accessed segments
> KVM: x86: Access to LDT/GDT that wraparound is incorrect
>
> arch/x86/include/asm/kvm_host.h | 12 ++++
> arch/x86/kvm/emulate.c | 138 ++++++++++++++++++++++++++--------------
> arch/x86/kvm/mmu.h | 12 ----
> 3 files changed, 103 insertions(+), 59 deletions(-)
>
I'm applying patches 2-8. I want to play a bit more with patch 1.
Paolo
prev parent reply other threads:[~2015-01-08 10:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 0:52 [PATCH 0/8] KVM: x86: Emulator fixes Nadav Amit
2014-12-25 0:52 ` [PATCH 1/8] KVM: x86: #PF error-code on R/W operations is wrong Nadav Amit
2014-12-26 7:25 ` Wu, Feng
2014-12-27 19:55 ` Nadav Amit
2014-12-25 0:52 ` [PATCH 2/8] KVM: x86: pop sreg accesses only 2 bytes Nadav Amit
2014-12-25 9:10 ` Chen, Tiejun
2014-12-25 9:55 ` Nadav Amit
2014-12-26 1:54 ` Chen, Tiejun
2014-12-26 7:25 ` Wu, Feng
2014-12-27 20:05 ` Nadav Amit
2014-12-25 0:52 ` [PATCH 3/8] KVM: x86: fnstcw and fnstsw may cause spurious exception Nadav Amit
2014-12-25 0:52 ` [PATCH 4/8] KVM: x86: JMP/CALL using call- or task-gate causes exception Nadav Amit
2014-12-25 0:52 ` [PATCH 5/8] KVM: x86: em_call_far should return failure result Nadav Amit
2014-12-25 0:52 ` [PATCH 6/8] KVM: x86: POP [ESP] is not emulated correctly Nadav Amit
2014-12-25 0:52 ` [PATCH 7/8] KVM: x86: Do not set access bit on accessed segments Nadav Amit
2014-12-25 0:52 ` [PATCH 8/8] KVM: x86: Access to LDT/GDT that wraparound is incorrect Nadav Amit
2014-12-27 22:24 ` [PATCH 0/8] KVM: x86: Emulator fixes Paolo Bonzini
2015-01-08 10:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE5F1A.2030204@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).