From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: Fix CR3_PCID_INVD type on 32-bit Date: Wed, 21 Jan 2015 15:59:23 +0100 Message-ID: <54BFBECB.1030306@redhat.com> References: <1421311496-18028-1-git-send-email-bp@alien8.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: LKML To: Borislav Petkov , KVM Return-path: Received: from mail-wg0-f53.google.com ([74.125.82.53]:39290 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbbAUO71 (ORCPT ); Wed, 21 Jan 2015 09:59:27 -0500 In-Reply-To: <1421311496-18028-1-git-send-email-bp@alien8.de> Sender: kvm-owner@vger.kernel.org List-ID: On 15/01/2015 09:44, Borislav Petkov wrote: > From: Borislav Petkov >=20 > arch/x86/kvm/emulate.c: In function =E2=80=98check_cr_write=E2=80=99: > arch/x86/kvm/emulate.c:3552:4: warning: left shift count >=3D width o= f type > rsvd =3D CR3_L_MODE_RESERVED_BITS & ~CR3_PCID_INVD; >=20 > happens because sizeof(UL) on 32-bit is 4 bytes but we shift it 63 bi= ts > to the left. >=20 > Signed-off-by: Borislav Petkov > --- > arch/x86/include/asm/kvm_host.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/k= vm_host.h > index d89c6b828c96..a8d07a060136 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -51,7 +51,7 @@ > | X86_CR0_NW | X86_CR0_CD | X86_CR0_PG)) > =20 > #define CR3_L_MODE_RESERVED_BITS 0xFFFFFF0000000000ULL > -#define CR3_PCID_INVD (1UL << 63) > +#define CR3_PCID_INVD BIT_64(63) > #define CR4_RESERVED_BITS = \ > (~(unsigned long)(X86_CR4_VME | X86_CR4_PVI | X86_CR4_TSD | X86_CR4= _DE\ > | X86_CR4_PSE | X86_CR4_PAE | X86_CR4_MCE \ >=20 Applied, thanks. Paolo