From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT?
Date: Thu, 22 Jan 2015 14:57:13 +0100
Message-ID: <54C101B9.1050804@redhat.com>
References: <1421918381.13638.43.camel@x220>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Gleb Natapov <gleb@kernel.org>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Paul Bolle <pebolle@tiscali.nl>,
	Mario Smarduch <m.smarduch@samsung.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1421918381.13638.43.camel@x220>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 22/01/2015 10:19, Paul Bolle wrote:
> Your commit ba0513b5b8ff ("KVM: Add generic support for dirty page
> logging") is included in today's linux-next (ie, next-20150122). I
> noticed because a script I use to check linux-next spotted a problem
> with it.
> 
> That commit added a Kconfig symbol HAVE_KVM_ARCH_DIRTY_LOG_PROTECT. But
> nothing in linux-next uses that symbol. Why was it added?

Ah, there are two Kconfig symbols added by mistake.

+config HAVE_KVM_ARCH_DIRTY_LOG_PROTECT
+ bool
+
+config KVM_GENERIC_DIRTYLOG_READ_PROTECT
+ bool

Christoffer, can you fix that in kvm-arm and also the other mistake that
Paul reported?

Paolo