From: "Jan Beulich" <JBeulich@suse.com>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
"David Vrabel" <david.vrabel@citrix.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
<rostedt@goodmis.org>,
"Masami Hiramatsu" <masami.hiramatsu.pt@hitachi.com>,
<x86@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>,
<paulmck@linux.vnet.ibm.com>, <xen-devel@lists.xenproject.org>,
<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>,
"Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@suse.de>,
<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] [RFC v4 2/2] x86/xen: allow privcmd hypercalls to be preempted
Date: Mon, 26 Jan 2015 10:46:03 +0000 [thread overview]
Message-ID: <54C628FB02000078000595C0@mail.emea.novell.com> (raw)
In-Reply-To: <20150123185812.GX17887@wotan.suse.de>
>>> On 23.01.15 at 19:58, <mcgrof@suse.com> wrote:
> On Fri, Jan 23, 2015 at 11:45:06AM +0000, David Vrabel wrote:
>> On 23/01/15 00:29, Luis R. Rodriguez wrote:
>> > @@ -1243,6 +1247,25 @@ void xen_evtchn_do_upcall(struct pt_regs *regs)
>> > set_irq_regs(old_regs);
>> > }
>> >
>> > +/*
>> > + * CONFIG_PREEMPT=n kernels can end up triggering the softlock
>> > + * TASK_UNINTERRUPTIBLE hanger check (default 120 seconds)
>> > + * when certain multicalls are used [0] on large systems, in
>> > + * that case we need a way to voluntarily preempt. This is
>> > + * only an issue on CONFIG_PREEMPT=n kernels.
>>
>> Rewrite this comment as;
>>
>> * Some hypercalls issued by the toolstack can take many 10s of
>
> Its not just hypercalls though, this is all about the interactions
> with multicalls no?
multicalls are just a special case of hypercalls.
Jan
next prev parent reply other threads:[~2015-01-26 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 0:29 [RFC v4 0/2] x86/xen: add xen hypercall preemption Luis R. Rodriguez
2015-01-23 0:29 ` [RFC v4 1/2] x86/xen: add xen_is_preemptible_hypercall() Luis R. Rodriguez
2015-01-23 1:40 ` Andy Lutomirski
2015-01-27 1:45 ` Luis R. Rodriguez
2015-01-23 11:30 ` [Xen-devel] " David Vrabel
2015-01-23 18:57 ` Luis R. Rodriguez
2015-01-23 0:29 ` [RFC v4 2/2] x86/xen: allow privcmd hypercalls to be preempted Luis R. Rodriguez
2015-01-23 1:40 ` Andy Lutomirski
2015-01-23 1:57 ` Steven Rostedt
2015-01-23 11:45 ` [Xen-devel] " David Vrabel
2015-01-23 18:58 ` Luis R. Rodriguez
2015-01-26 10:46 ` Jan Beulich [this message]
2015-01-26 10:47 ` David Vrabel
2015-01-23 19:16 ` Luis R. Rodriguez
2015-01-23 11:51 ` [Xen-devel] [RFC v4 0/2] x86/xen: add xen hypercall preemption David Vrabel
2015-01-23 18:58 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C628FB02000078000595C0@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox