From: Paolo Bonzini <pbonzini@redhat.com>
To: Wincy Van <fanwenyi0529@gmail.com>,
"gleb@kernel.org" <gleb@kernel.org>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.
Date: Tue, 27 Jan 2015 23:06:12 +0100 [thread overview]
Message-ID: <54C80BD4.5080800@redhat.com> (raw)
In-Reply-To: <CACzj_yVKMMJMdNjCn=64sqgEtcG9Jn3j=JitsprWB=hNnf19Ng@mail.gmail.com>
On 24/01/2015 11:18, Wincy Van wrote:
> v2 ---> v3:
> 1. Add a new field in nested_vmx to avoid the spin lock in v2.
> 2. Drop send eoi to L1 when doing nested interrupt delivery.
> 3. Use hardware MSR bitmap to enable nested virtualize x2apic
> mode.
I think the patches are mostly okay. I made a few comments.
One of the things to do on top could be to avoid rebuilding the whole
vmcs02 on every entry. Recomputing the MSR bitmap on every vmentry is
not particularly nice, for example. It is not necessary unless the
execution controls have changed.
Paolo
next prev parent reply other threads:[~2015-01-27 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 10:18 [PATCH v3 0/6] KVM: nVMX: Enable nested apicv support Wincy Van
2015-01-27 22:06 ` Paolo Bonzini [this message]
2015-01-28 6:37 ` Wincy Van
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C80BD4.5080800@redhat.com \
--to=pbonzini@redhat.com \
--cc=fanwenyi0529@gmail.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanpeng.li@linux.intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).