From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/8] KVM: x86: return bool from kvm_apic_match*()
Date: Fri, 30 Jan 2015 09:50:48 +0100
Message-ID: <54CB45E8.3030901@redhat.com>
References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com>	 <1422568135-28402-2-git-send-email-rkrcmar@redhat.com> <1422569401.16326.2.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Nadav Amit <namit@cs.technion.ac.il>,
	Gleb Natapov <gleb@kernel.org>
To: Joe Perches <joe@perches.com>,
	=?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1422569401.16326.2.camel@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 29/01/2015 23:10, Joe Perches wrote:
> On Thu, 2015-01-29 at 22:48 +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>> And don't export the internal ones while at it.
> []
>> -int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>> +static bool kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32=
 mda)
>>  {
>>  	int result =3D 0;
>>  	u32 logical_id;
>> @@ -626,7 +626,7 @@ int kvm_apic_match_logical_addr(struct kvm_lapic=
 *apic, u32 mda)
>>  	return result;
>>  }
>> =20
>> -int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *so=
urce,
>> +bool kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *s=
ource,
>>  			   int short_hand, unsigned int dest, int dest_mode)
>>  {
>>  	int result =3D 0;
>=20
> Perhaps these result variables should be bool.

See patch 2.

Paolo