From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/8] KVM: minor APIC fixes and cleanups Date: Fri, 30 Jan 2015 16:24:13 +0100 Message-ID: <54CBA21D.6050506@redhat.com> References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com> <54CB4D44.1080109@redhat.com> <20150130152031.GC28519@potion.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Nadav Amit , Gleb Natapov To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20150130152031.GC28519@potion.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 30/01/2015 16:20, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> > + /* XXX: A superset of x2APIC broadcasts is fine in practice as l= ong as >> > + * we don't support APIC ID > 0xfeffffff. >> > + */ >> >=20 >> > It's ugly. :) > Yeah, there is: don't deliver x2APIC broadcasts to xAPIC. > (I'm not even sure if it is correct ...) >=20 > Without that delivery, we could do something like > if (irq->dest_id =3D=3D (x2apic_ipi ? X2APIC_BROADCAST : APIC_BROAD= CAST)) Nadav, do you know what real hardware does? Paolo