From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/4] stubs for xsavec support Date: Mon, 02 Feb 2015 10:05:17 +0100 Message-ID: <54CF3DCD.6010607@redhat.com> References: <1420713159-25947-1-git-send-email-pbonzini@redhat.com> <1420713159-25947-2-git-send-email-pbonzini@redhat.com> <54CF2160.1010305@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit To: Jan Kiszka , kvm@vger.kernel.org Return-path: Received: from mail-wg0-f47.google.com ([74.125.82.47]:37514 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932677AbbBBJF1 (ORCPT ); Mon, 2 Feb 2015 04:05:27 -0500 Received: by mail-wg0-f47.google.com with SMTP id n12so37443352wgh.6 for ; Mon, 02 Feb 2015 01:05:26 -0800 (PST) In-Reply-To: <54CF2160.1010305@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/02/2015 08:04, Jan Kiszka wrote: >> > +#if X86_FEATURE_XSAVEOPT < 10 * 32 >> > +#undef X86_FEATURE_XSAVEOPT >> > +#endif >> > +#define X86_FEATURE_XSAVEOPT (10*32+0) /* XSAVEOPT instruction */ > This causes redefinition warnings if the condition is not met. Was the > plan to put the define before the #endif? The plan was to match the kernel's definition, which however has a space: #define X86_FEATURE_XSAVEOPT (10*32+ 0) But putting the define before the #endif also works. Paolo