From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 6/6] KVM: VMX: Add PML support in VMX Date: Tue, 03 Feb 2015 16:39:52 +0100 Message-ID: <54D0EBC8.6030301@redhat.com> References: <1422413668-3509-1-git-send-email-kai.huang@linux.intel.com> <1422413668-3509-7-git-send-email-kai.huang@linux.intel.com> <20150203151833.GD19731@potion.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: gleb@kernel.org, linux@arm.linux.org.uk, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Kai Huang Return-path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:50762 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933933AbbBCPj5 (ORCPT ); Tue, 3 Feb 2015 10:39:57 -0500 Received: by mail-wi0-f175.google.com with SMTP id fb4so25307924wid.2 for ; Tue, 03 Feb 2015 07:39:56 -0800 (PST) In-Reply-To: <20150203151833.GD19731@potion.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/02/2015 16:18, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > (I see the same code in handle_ept_violation(), but wasn't that neede= d > just because of a hardware error?) That was how I read it initially, but actually that means: "this statement could be broken if the processor has that erratum". >> +static void vmx_slot_enable_log_dirty(struct kvm *kvm, >> + struct kvm_memory_slot *slot) >> +{ >> + kvm_mmu_slot_leaf_clear_dirty(kvm, slot); >=20 > (New slot contains dirty pages?) New slots contain clean pages as far as the KVM dirty log is concerned. In the case of PML, note that D=3D1 does not mean the page is dirty. I= t only means that writes will not be logged by PML. The page may thus also have logging disabled. Paolo