From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 4/7] KVM: s390/CPACF: Choose crypto control block format Date: Wed, 04 Feb 2015 15:00:42 +0100 Message-ID: <54D2260A.5020902@de.ibm.com> References: <1423043092-34044-1-git-send-email-borntraeger@de.ibm.com> <1423043092-34044-5-git-send-email-borntraeger@de.ibm.com> <54D217F8.5050302@redhat.com> <54D2191C.9000604@de.ibm.com> <54D22319.4010009@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: KVM , Cornelia Huck , Jens Freimann , linux-s390 , Alexander Graf , Tony Krowiak To: Paolo Bonzini Return-path: Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:57440 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933674AbbBDOAt (ORCPT ); Wed, 4 Feb 2015 09:00:49 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Feb 2015 14:00:48 -0000 In-Reply-To: <54D22319.4010009@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 04.02.2015 um 14:48 schrieb Paolo Bonzini: > > > On 04/02/2015 14:05, Christian Borntraeger wrote: >>>> >>>> Could this also be part of the "things" that KVM can choose to enable, >>>> even though it's not a facility? >> Can you re-ask that question? Not sure what you want to know. >> >> This is mostly a fixup for z13, which wants to have a bigger control block. but >> this block is not guest visible. > > Okay, this is what I was asking. If the block is not guest visible > that's fine. > > What happens if the guest executes PQAP(QCI)? It will get an illegal opcode because we dont provide the PQAP instruction to the guest. (We have to provide it, if we want to virtualize the off-cpu crypto cards - right now we only provide the on-cpu crypto instructions)