From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/4] stubs for xsavec support
Date: Fri, 06 Feb 2015 20:40:38 +0100 [thread overview]
Message-ID: <54D518B6.9070101@siemens.com> (raw)
In-Reply-To: <54CF3DCD.6010607@redhat.com>
On 2015-02-02 10:05, Paolo Bonzini wrote:
>
>
> On 02/02/2015 08:04, Jan Kiszka wrote:
>>>> +#if X86_FEATURE_XSAVEOPT < 10 * 32
>>>> +#undef X86_FEATURE_XSAVEOPT
>>>> +#endif
>>>> +#define X86_FEATURE_XSAVEOPT (10*32+0) /* XSAVEOPT instruction */
>> This causes redefinition warnings if the condition is not met. Was the
>> plan to put the define before the #endif?
>
> The plan was to match the kernel's definition, which however has a space:
>
> #define X86_FEATURE_XSAVEOPT (10*32+ 0)
>
> But putting the define before the #endif also works.
Finally got my buildbot working again: There are some open issues, maybe
you can have a look at http://buildbot.kiszka.org/kvm-kmod/waterfall,
next branch. At least the 3.17 thing requires fixing but may require
more than a #define.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2015-02-06 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 10:32 [PATCH kvm-kmod 0/4] Update to 3.19-rc1 Paolo Bonzini
2015-01-08 10:32 ` [PATCH 1/4] stubs for xsavec support Paolo Bonzini
2015-02-02 7:04 ` Jan Kiszka
2015-02-02 9:05 ` Paolo Bonzini
2015-02-06 19:40 ` Jan Kiszka [this message]
2015-02-09 13:17 ` Paolo Bonzini
2015-02-09 13:44 ` Jan Kiszka
2015-02-09 13:45 ` Paolo Bonzini
2015-01-08 10:32 ` [PATCH 2/4] fixes for changes in the iommu and PCI APIs Paolo Bonzini
2015-01-08 10:32 ` [PATCH 3/4] fixes for changes in the percpu counter API Paolo Bonzini
2015-01-08 10:32 ` [PATCH 4/4] add trace_seq_buffer_ptr Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D518B6.9070101@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).