From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH] kvm: add halt_poll_ns module parameter Date: Mon, 09 Feb 2015 16:22:05 +0800 Message-ID: <54D86E2D.8010808@linux.intel.com> References: <1423226937-11169-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: riel@redhat.com, mtosatti@redhat.com, rkrcmar@redhat.com, jan.kiszka@siemens.com, dmatlack@google.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <1423226937-11169-1-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/06/2015 08:48 PM, Paolo Bonzini wrote: > > +unsigned int halt_poll_ns = 0; > +module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR); > + Can we make this parameter be changeable? So that we can tune it on the fly. > finish_wait(&vcpu->wq, &wait); > + cur = ktime_get(); We can move this into the tracepoint to avoid the workload if the tracepoint is not enabled. Otherwise looks good to me. Reviewed-by: Xiao Guangrong