From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: riel@redhat.com, mtosatti@redhat.com, rkrcmar@redhat.com,
jan.kiszka@siemens.com, dmatlack@google.com
Subject: Re: [PATCH] kvm: add halt_poll_ns module parameter
Date: Mon, 09 Feb 2015 18:12:04 +0800 [thread overview]
Message-ID: <54D887F4.8000903@linux.intel.com> (raw)
In-Reply-To: <54D878AF.5050707@redhat.com>
On 02/09/2015 05:06 PM, Paolo Bonzini wrote:
>
>
> On 09/02/2015 09:22, Xiao Guangrong wrote:
>>
>>
>> On 02/06/2015 08:48 PM, Paolo Bonzini wrote:
>>
>>>
>>> +unsigned int halt_poll_ns = 0;
>>> +module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>>> +
>>
>> Can we make this parameter be changeable? So that we can tune it
>> on the fly.
>
> It is changeable (S_IWUSR).
Oh... Yes, sorry for my careless.
>
>>> finish_wait(&vcpu->wq, &wait);
>>> + cur = ktime_get();
>>
>> We can move this into the tracepoint to avoid the workload if the
>> tracepoint is not enabled.
>
> You have a point. I didn't do it because I expect that halt_poll_ns
> will be always enabled as soon as it auto-tunes, and in that case you'll
> always have to do the ktime_get() for autotuning purposes.
Great, look forward to your future patches. ;)
next prev parent reply other threads:[~2015-02-09 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 12:48 [PATCH] kvm: add halt_poll_ns module parameter Paolo Bonzini
2015-02-09 8:22 ` Xiao Guangrong
2015-02-09 9:06 ` Paolo Bonzini
2015-02-09 10:12 ` Xiao Guangrong [this message]
2015-02-09 15:21 ` Radim Krčmář
2015-02-09 16:10 ` Paolo Bonzini
2015-02-09 17:28 ` Radim Krčmář
2015-02-09 19:52 ` David Matlack
2015-02-09 21:00 ` Christian Borntraeger
2015-02-10 7:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D887F4.8000903@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dmatlack@google.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).