From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: Reason for extra struct kvm_run parameter in MMIO handling?
Date: Mon, 09 Feb 2015 17:26:41 +0100
Message-ID: <54D8DFC1.9030103@redhat.com>
References: <54D4FA45.1000103@arm.com> <20150209162154.GA1804@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	Andre Przywara <andre.przywara@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58249 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932684AbbBIQ1J (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 9 Feb 2015 11:27:09 -0500
In-Reply-To: <20150209162154.GA1804@potion.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 09/02/2015 17:21, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> > So is that just legacy code still lingering around from the dawn of=
 time
> > and nobody dared to rework this or is there a particular reason for
> > doing so?
>=20
> Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.

Or microoptimization.  Laziness is more likely though.

> > I am asking because I lack the kvm_run pointer in the MMIO handler,=
 so I
> > just use vcpu->run and I wonder if there are potential issues in do=
ing so.
>
> We do it at few places already, so there, hopefully, is no problem.

Yup.  Thanks Radim for answering!

Paolo