From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@arm.com>
Subject: Re: Reason for extra struct kvm_run parameter in MMIO handling?
Date: Mon, 09 Feb 2015 17:22:16 +0000
Message-ID: <54D8ECC8.80609@arm.com>
References: <54D4FA45.1000103@arm.com> <20150209162154.GA1804@potion.brq.redhat.com> <54D8DFC1.9030103@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
To: Paolo Bonzini <pbonzini@redhat.com>,
	=?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:46822 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S933519AbbBIRW0 (ORCPT
	<rfc822;kvm@vger.kernel.org>); Mon, 9 Feb 2015 12:22:26 -0500
In-Reply-To: <54D8DFC1.9030103@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Radim, Paolo,

On 09/02/15 16:26, Paolo Bonzini wrote:
> On 09/02/2015 17:21, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>>> So is that just legacy code still lingering around from the dawn of=
 time
>>> and nobody dared to rework this or is there a particular reason for
>>> doing so?
>>
>> Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.
>=20
> Or microoptimization.  Laziness is more likely though.
>=20
>>> I am asking because I lack the kvm_run pointer in the MMIO handler,=
 so I
>>> just use vcpu->run and I wonder if there are potential issues in do=
ing so.
>>
>> We do it at few places already, so there, hopefully, is no problem.
>=20
> Yup.  Thanks Radim for answering!

thanks for the answer and the confirmation!
Looks like I don't dare to write a patch for that ;-)

Cheers,
Andre.