From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] KVM: x86: extract guest running logic from __vcpu_run
Date: Tue, 10 Feb 2015 09:18:10 +0100
Message-ID: <54D9BEC2.5020500@redhat.com>
References: <1423225019-11001-1-git-send-email-pbonzini@redhat.com> <1423225019-11001-2-git-send-email-pbonzini@redhat.com> <CALzav=e+_s7GUn4RoW73X-BZiZL0Ez3qaFFrnCRLiczdX83ngA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm list <kvm@vger.kernel.org>, riel@redhat.com,
	Marcelo Tosatti <mtosatti@redhat.com>, rkrcmar@redhat.com
To: David Matlack <dmatlack@google.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CALzav=e+_s7GUn4RoW73X-BZiZL0Ez3qaFFrnCRLiczdX83ngA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 09/02/2015 23:44, David Matlack wrote:
>> >
>> > +static inline int __vcpu_run(struct kvm *kvm, struct kvm_vcpu *vcpu)
> Kind of confusing function body given the name. Maybe put
> 
>        if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE &&
>            !vcpu->arch.apf.halted)
>                return vcpu_enter_guest(vcpu);
> 
> back in vcpu_run and rename this function? vcpu_wait?

Yeah, vcpu_wait or vcpu_block (since it calls kvm_vcpu_block) sound good.

Paolo