From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 12/21] KVM: x86: MOV to CR3 can set bit 63
Date: Tue, 10 Feb 2015 17:18:48 +0100
Message-ID: <54DA2F68.8080901@redhat.com>
References: <1414922101-17626-1-git-send-email-namit@cs.technion.ac.il> <1414922101-17626-13-git-send-email-namit@cs.technion.ac.il> <54DA2EBA.10803@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, nadav.amit@gmail.com
To: Jan Kiszka <jan.kiszka@siemens.com>,
	Nadav Amit <namit@cs.technion.ac.il>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37493 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750729AbbBJQTE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 Feb 2015 11:19:04 -0500
In-Reply-To: <54DA2EBA.10803@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 10/02/2015 17:15, Jan Kiszka wrote:
>> >  #define CR3_L_MODE_RESERVED_BITS 0xFFFFFF0000000000ULL
>> > +#define CR3_PCID_INVD		 (1UL << 63)
> 1ULL (for i386)

Already fixed:

commit cfaa790a3fb8a7efa98f4a6457e19dc3a0db35d3
Author: Borislav Petkov <bp@suse.de>
Date:   Thu Jan 15 09:44:56 2015 +0100

    kvm: Fix CR3_PCID_INVD type on 32-bit
   =20
    arch/x86/kvm/emulate.c: In function =E2=80=98check_cr_write=E2=80=99=
:
    arch/x86/kvm/emulate.c:3552:4: warning: left shift count >=3D width=
 of type
        rsvd =3D CR3_L_MODE_RESERVED_BITS & ~CR3_PCID_INVD;
   =20
    happens because sizeof(UL) on 32-bit is 4 bytes but we shift it 63 =
bits
    to the left.
   =20
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> Paolo, there is no 32-bit test build anymore on your side, right?

Reinstating it has been on my todo list for a while.  But as of now
I'm not doing 32-bit tests.

> I was
> about to drop them from kvm-kmod as well, but at least 2 remained in
> place and caught this.