From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 12/21] KVM: x86: MOV to CR3 can set bit 63 Date: Tue, 10 Feb 2015 17:42:43 +0100 Message-ID: <54DA3503.8050401@redhat.com> References: <1414922101-17626-1-git-send-email-namit@cs.technion.ac.il> <1414922101-17626-13-git-send-email-namit@cs.technion.ac.il> <54DA2EBA.10803@siemens.com> <54DA2F68.8080901@redhat.com> <54DA332C.30503@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, nadav.amit@gmail.com To: Jan Kiszka , Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43865 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbbBJQm4 (ORCPT ); Tue, 10 Feb 2015 11:42:56 -0500 In-Reply-To: <54DA332C.30503@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/02/2015 17:34, Jan Kiszka wrote: >> >=20 >> > commit cfaa790a3fb8a7efa98f4a6457e19dc3a0db35d3 >> > Author: Borislav Petkov >> > Date: Thu Jan 15 09:44:56 2015 +0100 >> >=20 >> > kvm: Fix CR3_PCID_INVD type on 32-bit >> > =20 >> > arch/x86/kvm/emulate.c: In function =E2=80=98check_cr_write=E2= =80=99: >> > arch/x86/kvm/emulate.c:3552:4: warning: left shift count >=3D = width of type >> > rsvd =3D CR3_L_MODE_RESERVED_BITS & ~CR3_PCID_INVD; >> > =20 >> > happens because sizeof(UL) on 32-bit is 4 bytes but we shift i= t 63 bits >> > to the left. >> > =20 >> > Signed-off-by: Borislav Petkov >> > Signed-off-by: Paolo Bonzini > Ah, sorry. Your kvm-kmod queue lacked a source link update! >=20 > Is this queued for stable as well? It's not in 3.19 apparently. I'll queue it for stable as soon as it hits Linus's tree. Thanks, Paolo