From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 4/5] add single_task_running Date: Tue, 10 Feb 2015 17:46:19 +0100 Message-ID: <54DA35DB.2000501@siemens.com> References: <1423574042-5785-1-git-send-email-pbonzini@redhat.com> <1423574042-5785-5-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit To: Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from thoth.sbs.de ([192.35.17.2]:59832 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbbBJQq0 (ORCPT ); Tue, 10 Feb 2015 11:46:26 -0500 In-Reply-To: <1423574042-5785-5-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2015-02-10 14:14, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > external-module-compat-comm.h | 4 ++++ > external-module-compat.c | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h > index d683c30..456ebf8 100644 > --- a/external-module-compat-comm.h > +++ b/external-module-compat-comm.h > @@ -1453,6 +1453,10 @@ static inline void pci_set_dev_assigned(struct pci_dev *pdev) > void *get_xsave_addr(struct xsave_struct *xsave, int feature); > #endif > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0) > +bool single_task_running(void); > +#endif > + > #if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0) > #define trace_seq_buffer_ptr(p) ((p)->buffer + (p)->len) > #endif > diff --git a/external-module-compat.c b/external-module-compat.c > index 347d20e..1d9a742 100644 > --- a/external-module-compat.c > +++ b/external-module-compat.c > @@ -373,3 +373,11 @@ void *get_xsave_addr(struct xsave_struct *xsave, int feature) > return (u8 *)xsave + offset; > } > #endif > + > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0) > +bool single_task_running(void) > +{ > + /* Not exactly the same... */ > + return !need_resched(); > +} > +#endif > 3.15 and earlier lacks ktime_before in addition, see e.g. http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.15-x86-64/logs/stdio I'm not yet sure where to cut backward support now, maybe 3.10 (LTS). 3.9 gives a strange warning in __do_insn_fetch_bytes though the involved code should be identical to building for newer kernels: http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.9-x86-64/logs/stdio Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux