From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 4/5] add single_task_running
Date: Tue, 10 Feb 2015 17:55:27 +0100 [thread overview]
Message-ID: <54DA37FF.6060303@redhat.com> (raw)
In-Reply-To: <54DA35DB.2000501@siemens.com>
On 10/02/2015 17:46, Jan Kiszka wrote:
>> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0)
>> > +bool single_task_running(void)
>> > +{
>> > + /* Not exactly the same... */
>> > + return !need_resched();
>> > +}
>> > +#endif
>> >
> 3.15 and earlier lacks ktime_before in addition, see e.g.
> http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.15-x86-64/logs/stdio
Ah... indeed I tested with 3.16 (that's what I usually use when I'm not
compiling the whole kernel, because RHEL7.1's KVM is based on 3.16).
> I'm not yet sure where to cut backward support now, maybe 3.10 (LTS).
Yeah, either 3.2 or 3.10 I guess. (Is Debian still using 3.2?)
> 3.9 gives a strange warning in __do_insn_fetch_bytes though the involved
> code should be identical to building for newer kernels:
>
> http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.9-x86-64/logs/stdio
Weird...
Paolo
next prev parent reply other threads:[~2015-02-10 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 13:13 [PATCH kvm-kmod 0/5] update for 3.20-rc1 (roughly) Paolo Bonzini
2015-02-10 13:13 ` [PATCH 1/5] add AVX512 features Paolo Bonzini
2015-02-10 13:13 ` [PATCH 2/5] fix missing get_xsave_addr in kernels 3.17-3.18.2 Paolo Bonzini
2015-02-10 13:14 ` [PATCH 3/5] add CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT Paolo Bonzini
2015-02-10 13:14 ` [PATCH 4/5] add single_task_running Paolo Bonzini
2015-02-10 16:46 ` Jan Kiszka
2015-02-10 16:55 ` Paolo Bonzini [this message]
2015-02-10 13:14 ` [PATCH 5/5] tweak replacement for POSTED_INTR_VECTOR Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DA37FF.6060303@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).