From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/5] add single_task_running Date: Tue, 10 Feb 2015 17:55:27 +0100 Message-ID: <54DA37FF.6060303@redhat.com> References: <1423574042-5785-1-git-send-email-pbonzini@redhat.com> <1423574042-5785-5-git-send-email-pbonzini@redhat.com> <54DA35DB.2000501@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit To: Jan Kiszka , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58628 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbbBJQ4F (ORCPT ); Tue, 10 Feb 2015 11:56:05 -0500 In-Reply-To: <54DA35DB.2000501@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/02/2015 17:46, Jan Kiszka wrote: >> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0) >> > +bool single_task_running(void) >> > +{ >> > + /* Not exactly the same... */ >> > + return !need_resched(); >> > +} >> > +#endif >> > > 3.15 and earlier lacks ktime_before in addition, see e.g. > http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.15-x86-64/logs/stdio Ah... indeed I tested with 3.16 (that's what I usually use when I'm not compiling the whole kernel, because RHEL7.1's KVM is based on 3.16). > I'm not yet sure where to cut backward support now, maybe 3.10 (LTS). Yeah, either 3.2 or 3.10 I guess. (Is Debian still using 3.2?) > 3.9 gives a strange warning in __do_insn_fetch_bytes though the involved > code should be identical to building for newer kernels: > > http://buildbot.kiszka.org/kvm-kmod/builders/3-next/builds/395/steps/3.9-x86-64/logs/stdio Weird... Paolo