From mboxrd@z Thu Jan  1 00:00:00 1970
From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Subject: Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions
Date: Thu, 12 Feb 2015 00:08:17 +0530
Message-ID: <54DBA199.8070708@linux.vnet.ibm.com>
References: <1423234148-13886-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <54D7D19B.1000103@goop.org> <54D87F1E.9060307@linux.vnet.ibm.com> <20150209120227.GT21418@twins.programming.kicks-ass.net> <CA+55aFympdPOotzEgdhQULidN+nxb-VUdfym+qU9LOsHScvpzw@mail.gmail.com> <54D9CFC7.5020007@linux.vnet.ibm.com> <20150210132634.GA30380@redhat.com> <54DB384A.2050305@linux.vnet.ibm.com> <20150211173838.GB28689@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Peter Anvin <hpa@zytor.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	Waiman Long <waiman.long@hp.com>,
	Dave Jones <davej@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Andi Kleen <ak@linux.intel.com>,
	Jason Wang <jasowang@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	xen-devel@lists.xenproject.org, Rik van Riel <riel@redhat.com>,
	Christian B
To: Oleg Nesterov <oleg@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20150211173838.GB28689@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 02/11/2015 11:08 PM, Oleg Nesterov wrote:
> On 02/11, Raghavendra K T wrote:
>>
>> On 02/10/2015 06:56 PM, Oleg Nesterov wrote:
>>
>>> In this case __ticket_check_and_clear_slowpath() really needs to cmpxchg
>>> the whole .head_tail. Plus obviously more boring changes. This needs a
>>> separate patch even _if_ this can work.
>>
>> Correct, but apart from this, before doing xadd in unlock,
>> we would have to make sure lsb bit is cleared so that we can live with 1
>> bit overflow to tail which is unused. now either or both of head,tail
>> lsb bit may be set after unlock.
>
> Sorry, can't understand... could you spell?
>
> If TICKET_SLOWPATH_FLAG lives in .head arch_spin_unlock() could simply do
>
> 	head = xadd(&lock->tickets.head, TICKET_LOCK_INC);
>
> 	if (head & TICKET_SLOWPATH_FLAG)
> 		__ticket_unlock_kick(head);
>
> so it can't overflow to .tail?
>

You are right.
I totally forgot we can get rid of tail operations :)

>
> And we we do this, probably it makes sense to add something like
>
> 	bool tickets_equal(__ticket_t one, __ticket_t two)
> 	{
> 		return (one ^ two) & ~TICKET_SLOWPATH_FLAG;
> 	}
>

Very nice idea. I was tired of ~TICKET_SLOWPATH_FLAG usage all over in
the current (complex :)) implementation. These two suggestions helps
alot.

> and change kvm_lock_spinning() to use tickets_equal(tickets.head, want), plus
> it can have more users in asm/spinlock.h.