* Re: Build warning for unused function in the file,sm7xxfb.c
[not found] ` <20150226164800.GB4609@kroah.com>
@ 2015-02-27 15:14 ` Sudip Mukherjee
2015-02-27 15:21 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2015-02-27 15:14 UTC (permalink / raw)
To: Greg KH, Gleb Natapov, Paolo Bonzini, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86, Nick Krause
Cc: linux-fbdev, kvm, linux-kernel
On Thu, Feb 26, 2015 at 08:48:00AM -0800, Greg KH wrote:
> On Thu, Feb 26, 2015 at 10:44:00AM +0530, Sudip Mukherjee wrote:
> > On Wed, Feb 25, 2015 at 08:33:41PM -0800, Greg KH wrote:
> > > On Thu, Feb 26, 2015 at 09:57:31AM +0530, Sudip Mukherjee wrote:
> > >
> > > I suggest updating your personal blacklist as well, it makes things
> > > easier.
> > yes, better. and i was just seeing some of his patches, mostly all are removing of FIXME comments.
> >
> > but i got confused with bab5bb398273bb37547a185f7b344b37c700d0b9
> > he has removed a call to function kvm_make_request() and introduced a new function kvm_set_pending_timer() which is just calling kvm_make_request(). and the commit message just says "Adds a function kvm_vcpu_set_pending_timer instead of calling kvm_make_request in lapic.c." , i am just unable to understand why this change?
>
> I don't understand the change either, I suggest asking the kvmm
> developer who accepted it.
Hi Paolo,
We have a small confusion about commit bab5bb398273bb37547a185f7b344b37c700d0b9. It looks like the patch removed a call to function kvm_make_request() and introduced a new function kvm_set_pending_timer() which is just calling kvm_make_request() again. and the commit message just says "Adds a function kvm_vcpu_set_pending_timer instead of calling kvm_make_request in lapic.c.".
regards
sudip
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build warning for unused function in the file,sm7xxfb.c
2015-02-27 15:14 ` Build warning for unused function in the file,sm7xxfb.c Sudip Mukherjee
@ 2015-02-27 15:21 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-02-27 15:21 UTC (permalink / raw)
To: Sudip Mukherjee, Greg KH, Gleb Natapov, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86, Nick Krause
Cc: linux-fbdev, kvm, linux-kernel
On 27/02/2015 16:14, Sudip Mukherjee wrote:
>>> I don't understand the change either, I suggest asking the kvmm
>>> developer who accepted it.
> Hi Paolo, We have a small confusion about commit
> bab5bb398273bb37547a185f7b344b37c700d0b9. It looks like the patch
> removed a call to function kvm_make_request() and introduced a new
> function kvm_set_pending_timer() which is just calling
> kvm_make_request() again. and the commit message just says "Adds a
> function kvm_vcpu_set_pending_timer instead of calling
> kvm_make_request in lapic.c.".
It's just a cosmetic change; and yes, I know who the author is.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-27 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54EE9B46.3090103@gmail.com>
[not found] ` <20150226042731.GA3609@sudip-PC>
[not found] ` <20150226043341.GA8294@kroah.com>
[not found] ` <20150226051400.GA4178@sudip-PC>
[not found] ` <20150226164800.GB4609@kroah.com>
2015-02-27 15:14 ` Build warning for unused function in the file,sm7xxfb.c Sudip Mukherjee
2015-02-27 15:21 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).