From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" Date: Tue, 03 Mar 2015 21:43:53 +0100 Message-ID: <54F61D09.2020601@suse.de> References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> <54F468D5.2060407@suse.de> <54F46AF7.60209@suse.de> <54F50366.6080105@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-stable@nongnu.org, Paolo Bonzini , qemu-ppc , kvm To: Alexey Kardashevskiy , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:42585 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755806AbbCCUnz (ORCPT ); Tue, 3 Mar 2015 15:43:55 -0500 In-Reply-To: <54F50366.6080105@ozlabs.ru> Sender: kvm-owner@vger.kernel.org List-ID: On 03.03.15 01:42, Alexey Kardashevskiy wrote: > On 03/03/2015 12:51 AM, Alexander Graf wrote: >> >> >> On 02.03.15 14:42, Andreas F=C3=A4rber wrote: >>> Am 02.03.2015 um 14:37 schrieb Alexander Graf: >>>> On 01.03.15 01:31, Andreas F=C3=A4rber wrote: >>>>> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to a= void >>>>> double-registration of types: >>>>> >>>>> Registering `POWER5+-powerpc64-cpu' which already exists >>>>> >>>>> Taking the textual description of a CPU type as part of a new typ= e >>>>> name >>>>> is plain wrong, and so is unconditionally registering a new type = here. >>>>> >>>>> Cc: Alexey Kardashevskiy >>>>> Cc: qemu-stable@nongnu.org >>>>> Signed-off-by: Andreas F=C3=A4rber >>>> >>>> Doesn't this break p8 support? >>> >>> Maybe, but p5 support was in longer and this is definitely a regres= sion >>> and really really wrong. If you know a way to fix it without handin= g it >>> back to the IBM guys for more thought, feel free to give it a shot. >> >> I honestly don't fully remember what this was about. Wasn't this our >> special KVM class that we use to create a compatible cpu type on the= fly? >> >> Alexey, please take a look at it. >=20 >=20 > I sent a note yesterday :-/ Here it is again: >=20 > With this revert, running qemu with HV KVM and -cpu POWER7 fails on r= eal > POWER7 machine as my machine has pvr 003f 0201 and POWER7 is an alias= of > POWER7_v2.3 (pvr 003f 0203); and this is what I tried to fix at the > first place. QEMU looks at classes first, and if not found - at alias= es, > so this worked. >=20 > I would rename "POWER5+" to "POWER5+_0.0" and make "POWER5+" an alias > for POWER5+_v2.1 (or POWER5+_0.0). Care to send a patch? Alex