From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH] KVM: make halt_poll_ns static Date: Tue, 03 Mar 2015 22:46:16 +0100 Message-ID: <54F62BA8.4000401@de.ibm.com> References: <1425052210-27497-1-git-send-email-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , Marcelo Tosatti , KVM To: Bandan Das Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:35144 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756607AbbCCVqV (ORCPT ); Tue, 3 Mar 2015 16:46:21 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2015 21:46:19 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AC37617D805F for ; Tue, 3 Mar 2015 21:46:36 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t23LkHJ610027314 for ; Tue, 3 Mar 2015 21:46:17 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t23LkH6F011255 for ; Tue, 3 Mar 2015 14:46:17 -0700 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 03.03.2015 um 22:42 schrieb Bandan Das: > Christian Borntraeger writes: > >> halt_poll_ns is used only locally. Make it static. >> >> Signed-off-by: Christian Borntraeger >> --- >> virt/kvm/kvm_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 34310a8..58bc2a9 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -66,7 +66,7 @@ >> MODULE_AUTHOR("Qumranet"); >> MODULE_LICENSE("GPL"); >> >> -unsigned int halt_poll_ns = 0; >> +static unsigned int halt_poll_ns = 0; > > We should remove the initialization to zero. (Unfortunately, > the usage pattern throughout the kernel code is not constant..) Yes, static unsigned int halt_poll_ns; will do. Paolo, Marcelo, I can add v2 to the next s390 pull request as below if you like. halt_poll_ns is used only locally. Make it static and remove the initializer. diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 34310a8..58bc2a9 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -66,7 +66,7 @@ MODULE_AUTHOR("Qumranet"); MODULE_LICENSE("GPL"); -unsigned int halt_poll_ns = 0; +static unsigned int halt_poll_ns; module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR); /* Otherwise I will resend. to