* [PATCH] KVM: make halt_poll_ns static
@ 2015-02-27 15:50 Christian Borntraeger
2015-03-03 21:42 ` Bandan Das
2015-03-09 21:38 ` Marcelo Tosatti
0 siblings, 2 replies; 5+ messages in thread
From: Christian Borntraeger @ 2015-02-27 15:50 UTC (permalink / raw)
To: Paolo Bonzini, Marcelo Tosatti; +Cc: KVM, Christian Borntraeger
halt_poll_ns is used only locally. Make it static.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 34310a8..58bc2a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -66,7 +66,7 @@
MODULE_AUTHOR("Qumranet");
MODULE_LICENSE("GPL");
-unsigned int halt_poll_ns = 0;
+static unsigned int halt_poll_ns = 0;
module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
/*
--
2.3.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: make halt_poll_ns static
2015-02-27 15:50 [PATCH] KVM: make halt_poll_ns static Christian Borntraeger
@ 2015-03-03 21:42 ` Bandan Das
2015-03-03 21:46 ` Christian Borntraeger
2015-03-09 21:38 ` Marcelo Tosatti
1 sibling, 1 reply; 5+ messages in thread
From: Bandan Das @ 2015-03-03 21:42 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Paolo Bonzini, Marcelo Tosatti, KVM
Christian Borntraeger <borntraeger@de.ibm.com> writes:
> halt_poll_ns is used only locally. Make it static.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns = 0;
We should remove the initialization to zero. (Unfortunately,
the usage pattern throughout the kernel code is not constant..)
Bandan
> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>
> /*
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: make halt_poll_ns static
2015-03-03 21:42 ` Bandan Das
@ 2015-03-03 21:46 ` Christian Borntraeger
2015-03-09 12:15 ` Christian Borntraeger
0 siblings, 1 reply; 5+ messages in thread
From: Christian Borntraeger @ 2015-03-03 21:46 UTC (permalink / raw)
To: Bandan Das; +Cc: Paolo Bonzini, Marcelo Tosatti, KVM
Am 03.03.2015 um 22:42 schrieb Bandan Das:
> Christian Borntraeger <borntraeger@de.ibm.com> writes:
>
>> halt_poll_ns is used only locally. Make it static.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> virt/kvm/kvm_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 34310a8..58bc2a9 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -66,7 +66,7 @@
>> MODULE_AUTHOR("Qumranet");
>> MODULE_LICENSE("GPL");
>>
>> -unsigned int halt_poll_ns = 0;
>> +static unsigned int halt_poll_ns = 0;
>
> We should remove the initialization to zero. (Unfortunately,
> the usage pattern throughout the kernel code is not constant..)
Yes,
static unsigned int halt_poll_ns;
will do.
Paolo, Marcelo,
I can add v2 to the next s390 pull request as below if you like.
halt_poll_ns is used only locally. Make it static and remove
the initializer.
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 34310a8..58bc2a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -66,7 +66,7 @@
MODULE_AUTHOR("Qumranet");
MODULE_LICENSE("GPL");
-unsigned int halt_poll_ns = 0;
+static unsigned int halt_poll_ns;
module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
/*
Otherwise I will resend.
to
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: make halt_poll_ns static
2015-03-03 21:46 ` Christian Borntraeger
@ 2015-03-09 12:15 ` Christian Borntraeger
0 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2015-03-09 12:15 UTC (permalink / raw)
To: Bandan Das; +Cc: Paolo Bonzini, Marcelo Tosatti, KVM
Am 03.03.2015 um 22:46 schrieb Christian Borntraeger:
[...]
>
> halt_poll_ns is used only locally. Make it static and remove
> the initializer.
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns;
> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>
> /*
>
>
> Otherwise I will resend.
Ping. Do you want me to send that via my next pull request for s390 or shall I
resend as a standalone patch for you to apply?
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: make halt_poll_ns static
2015-02-27 15:50 [PATCH] KVM: make halt_poll_ns static Christian Borntraeger
2015-03-03 21:42 ` Bandan Das
@ 2015-03-09 21:38 ` Marcelo Tosatti
1 sibling, 0 replies; 5+ messages in thread
From: Marcelo Tosatti @ 2015-03-09 21:38 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Paolo Bonzini, KVM
On Fri, Feb 27, 2015 at 04:50:10PM +0100, Christian Borntraeger wrote:
> halt_poll_ns is used only locally. Make it static.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-09 21:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 15:50 [PATCH] KVM: make halt_poll_ns static Christian Borntraeger
2015-03-03 21:42 ` Bandan Das
2015-03-03 21:46 ` Christian Borntraeger
2015-03-09 12:15 ` Christian Borntraeger
2015-03-09 21:38 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox