From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" Date: Wed, 04 Mar 2015 15:55:24 +0100 Message-ID: <54F71CDC.7000102@suse.de> References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> <54F468D5.2060407@suse.de> <54F46AF7.60209@suse.de> <54F50366.6080105@ozlabs.ru> <54F61D09.2020601@suse.de> <54F63232.9090202@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-stable@nongnu.org, Paolo Bonzini , qemu-ppc , kvm To: Alexey Kardashevskiy , Alexander Graf , qemu-devel@nongnu.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:57719 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755514AbbCDOz0 (ORCPT ); Wed, 4 Mar 2015 09:55:26 -0500 In-Reply-To: <54F63232.9090202@ozlabs.ru> Sender: kvm-owner@vger.kernel.org List-ID: Am 03.03.2015 um 23:14 schrieb Alexey Kardashevskiy: > On 03/04/2015 07:43 AM, Alexander Graf wrote: >> On 03.03.15 01:42, Alexey Kardashevskiy wrote: >>> On 03/03/2015 12:51 AM, Alexander Graf wrote: >>>> On 02.03.15 14:42, Andreas F=C3=A4rber wrote: >>>>> Am 02.03.2015 um 14:37 schrieb Alexander Graf: >>>>>> On 01.03.15 01:31, Andreas F=C3=A4rber wrote: >>>>>>> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to >>>>>>> avoid >>>>>>> double-registration of types: >>>>>>> >>>>>>> Registering `POWER5+-powerpc64-cpu' which already exists >>>>>>> >>>>>>> Taking the textual description of a CPU type as part of a new t= ype >>>>>>> name >>>>>>> is plain wrong, and so is unconditionally registering a new typ= e >>>>>>> here. >>>>>>> >>>>>>> Cc: Alexey Kardashevskiy >>>>>>> Cc: qemu-stable@nongnu.org >>>>>>> Signed-off-by: Andreas F=C3=A4rber >>>>>> >>>>>> Doesn't this break p8 support? >>>>> >>>>> Maybe, but p5 support was in longer and this is definitely a >>>>> regression >>>>> and really really wrong. If you know a way to fix it without >>>>> handing it >>>>> back to the IBM guys for more thought, feel free to give it a sho= t. >>>> >>>> I honestly don't fully remember what this was about. Wasn't this o= ur >>>> special KVM class that we use to create a compatible cpu type on t= he >>>> fly? >>>> >>>> Alexey, please take a look at it. >>> >>> >>> I sent a note yesterday :-/ Here it is again: >>> >>> With this revert, running qemu with HV KVM and -cpu POWER7 fails on= real >>> POWER7 machine as my machine has pvr 003f 0201 and POWER7 is an ali= as of >>> POWER7_v2.3 (pvr 003f 0203); and this is what I tried to fix at the >>> first place. QEMU looks at classes first, and if not found - at ali= ases, >>> so this worked. >>> >>> I would rename "POWER5+" to "POWER5+_0.0" and make "POWER5+" an ali= as >>> for POWER5+_v2.1 (or POWER5+_0.0). >> >> Care to send a patch? >=20 > I wonder if Andreas has a better solution to my initial problem - he > obviously won't like the proposed patch :) Quite predictable, am I? ;) Could you please explain in detail what problem you are seeing on POWER= 8 without this patch? =46rom your new patch it rather sounds as if this was totally unrelated= to -cpu host and a new KVM-only feature, reinforcing my feeling that my function is the wrong place for your code. Also, as I pointed out, the description cannot safely be used as part o= f the type name, as it may contain prohibited characters, so this still needs fixing. And for sure, if registering new types is indeed needed here, then a check is needed for whether that type already exists and appropriate error handling. I just don't understand why that is needed at all with -cpu host taking the PVR as you say is needed here. If you can precisely tell me what it is that you need then I'd be happy to cook up a patch. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmany= u, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)