From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH stable 3.10, 3.12, 3.14] MIPS: Export FP functions used by lose_fpu(1) for KVM Date: Sat, 07 Mar 2015 14:30:27 +0100 Message-ID: <54FAFD73.9030500@suse.cz> References: <54F7BE2E.8070708@roeck-us.net> <1425571724-9480-1-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, satoru.takeuchi@gmail.com, shuah.kh@samsung.com, stable@vger.kernel.org, Greg Kroah-Hartman , linux-mips@linux-mips.org, Paolo Bonzini , Ralf Baechle , Paul Burton , Gleb Natapov , kvm@vger.kernel.org To: James Hogan , Guenter Roeck Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:43117 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbbCGNac (ORCPT ); Sat, 7 Mar 2015 08:30:32 -0500 In-Reply-To: <1425571724-9480-1-git-send-email-james.hogan@imgtec.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/05/2015, 05:08 PM, James Hogan wrote: > [ Upstream commit 3ce465e04bfd8de9956d515d6e9587faac3375dc ] > > Export the _save_fp asm function used by the lose_fpu(1) macro to GPL > modules so that KVM can make use of it when it is built as a module. > > This fixes the following build error when CONFIG_KVM=m due to commit > f798217dfd03 ("KVM: MIPS: Don't leak FPU/DSP to guest"): > > ERROR: "_save_fp" [arch/mips/kvm/kvm.ko] undefined! > > Signed-off-by: James Hogan > Fixes: f798217dfd03 (KVM: MIPS: Don't leak FPU/DSP to guest) > Cc: Paolo Bonzini > Cc: Ralf Baechle > Cc: Paul Burton > Cc: Gleb Natapov > Cc: kvm@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: # 3.10...3.15 > Patchwork: https://patchwork.linux-mips.org/patch/9260/ > Signed-off-by: Ralf Baechle > [james.hogan@imgtec.com: Only export when CPU_R4K_FPU=y prior to v3.16, > so as not to break the Octeon build which excludes FPU support. KVM > depends on MIPS32r2 anyway.] > Signed-off-by: James Hogan > --- > Appologies for the previous cavium_octeon_defconfig link breakage. > Octeon has the symbol since 3.16, but not before. This backport should > do the trick for stable 3.10, 3.12, and 3.14. Build tested with > cavium_octeon_defconfig and malta_kvm_defconfig on those stable > branches. Applied to 3.12 now. Thanks. -- js suse labs