From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] KVM: make halt_poll_ns static
Date: Mon, 09 Mar 2015 13:15:59 +0100
Message-ID: <54FD8EFF.1030902@de.ibm.com>
References: <1425052210-27497-1-git-send-email-borntraeger@de.ibm.com> <jpg61ahrc4q.fsf@redhat.com> <54F62BA8.4000401@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KVM <kvm@vger.kernel.org>
To: Bandan Das <bsd@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:53559 "EHLO
	e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750898AbbCIMRF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 9 Mar 2015 08:17:05 -0400
Received: from /spool/local
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <borntraeger@de.ibm.com>;
	Mon, 9 Mar 2015 12:17:03 -0000
Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id F08CA17D8042
	for <kvm@vger.kernel.org>; Mon,  9 Mar 2015 12:17:21 +0000 (GMT)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t29CH07P10092920
	for <kvm@vger.kernel.org>; Mon, 9 Mar 2015 12:17:00 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t29CGPoj015567
	for <kvm@vger.kernel.org>; Mon, 9 Mar 2015 06:17:00 -0600
In-Reply-To: <54F62BA8.4000401@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 03.03.2015 um 22:46 schrieb Christian Borntraeger:
[...]
> 
> halt_poll_ns is used only locally. Make it static and remove 
> the initializer.
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
>  MODULE_AUTHOR("Qumranet");
>  MODULE_LICENSE("GPL");
> 
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns;
>  module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
> 
>  /*
> 
> 
> Otherwise I will resend.

Ping. Do you want me to send that via my next pull request for s390 or shall I 
resend as a standalone patch for you to apply?

Christian