From: James Sullivan <sullivan.james.f@gmail.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, gleb@kernel.org
Subject: Re: [Patch v4] x86: irq_comm: Add check for RH bit in kvm_set_msi_irq
Date: Fri, 13 Mar 2015 08:47:33 -0600 [thread overview]
Message-ID: <5502F885.7080508@gmail.com> (raw)
In-Reply-To: <20150313143957.GA17349@potion.brq.redhat.com>
On 03/13/2015 08:39 AM, Radim Krčmář wrote:
...
> The warning message is very clever:
> - it contains the magical "may" qualifier and being protected only by
> RH=1 creates weird-looking code structure, but it is technically right
> 1) lowest-priority delivery may be set in msi.data, which avoids our
> otherwise incorrect behavior with RH=1/DM=1
> 2) RH=1/DM=0 can't deliver to multiple APICs (broadcast is forbidden),
> but real hardware may overwrite delivery mode from msi.data
> - being two lines apart adds to suspicion, yet it can be hint to those
> possible problems
>
> I only fear it is too clever :)
>
For the error message, how does:
kvm: MSI RH=1 unsupported, use low-priority delivery mode
Sit with you?
-James
next prev parent reply other threads:[~2015-03-13 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 23:41 [Patch v3] x86: irq_comm: Add check for RH bit in kvm_set_msi_irq James Sullivan
2015-03-13 2:50 ` James Sullivan
2015-03-13 3:08 ` [Patch v4] " James Sullivan
2015-03-13 14:39 ` Radim Krčmář
2015-03-13 14:47 ` James Sullivan [this message]
2015-03-13 15:08 ` Radim Krčmář
2015-03-13 15:12 ` James Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502F885.7080508@gmail.com \
--to=sullivan.james.f@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).