From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiubo Li Subject: Re: [PATCH 3/3] KVM: For the symbols used locally only should bestatic type. Date: Mon, 16 Mar 2015 08:45:06 +0800 Message-ID: <55062792.9000403@cmss.chinamobile.com> References: <1426239586-1369-1-git-send-email-lixiubo@cmss.chinamobile.com> <1426239586-1369-4-git-send-email-lixiubo@cmss.chinamobile.com> <5502E819.7010609@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org To: Christian Borntraeger , mtosatti@redhat.com Return-path: Received: from cmccmta2.chinamobile.com ([221.176.66.80]:2859 "HELO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750872AbbCPApc (ORCPT ); Sun, 15 Mar 2015 20:45:32 -0400 In-Reply-To: <5502E819.7010609@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 13/03/2015 21:37, Christian Borntraeger wrote: > Am 13.03.2015 um 10:39 schrieb Xiubo Li: >> This patch fix the following sparse warnings: >> >> for file virt/kvm/kvm_main.c: >> warning: symbol 'halt_poll_ns' was not declared. Should it be static? >> >> Signed-off-by: Xiubo Li >> --- >> virt/kvm/kvm_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index a109370..a23d2ba 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -66,7 +66,7 @@ >> MODULE_AUTHOR("Qumranet"); >> MODULE_LICENSE("GPL"); >> >> -unsigned int halt_poll_ns = 0; >> +static unsigned int halt_poll_ns; >> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR); >> >> /* >> > This change is already part of kvm/queue > > https://git.kernel.org/cgit/virt/kvm/kvm.git/commit/?h=queue&id=0fa9778895635ab3824caf34fd573562dd2b999c > Yes, right, before this patch, i had already synced the newest version, but didn't find this patch. I will abandon it. Thanks, BRs Xiubo