* [PATCH v4 2/4] kvm/ppc/mpic: drop unused IRQ_testbit [not found] <550C0760.50903@suse.de> @ 2015-03-21 6:56 ` Arseny Solokha 2015-03-21 14:54 ` Alexander Graf 0 siblings, 1 reply; 2+ messages in thread From: Arseny Solokha @ 2015-03-21 6:56 UTC (permalink / raw) To: Alexander Graf; +Cc: kvm, kvm-ppc, linuxppc-dev, linux-kernel, Arseny Solokha Drop unused static procedure which doesn't have callers within its translation unit. It had been already removed independently in QEMU[1] from the OpenPIC implementation borrowed by the kernel. [1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html v4: Fixed the comment regarding the origination of OpenPIC codebase and CC'ed KVM mailing lists, as suggested by Alexander Graf. v3: In patch 4/4, do not remove fsl_mpic_primary_get_version() from arch/powerpc/sysdev/mpic.c because the patch by Jia Hongtao ("powerpc/85xx: workaround for chips with MSI hardware errata") makes use of it. v2: Added a brief explanation to each patch description of why removed functions are unused, as suggested by Michael Ellerman. Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> --- arch/powerpc/kvm/mpic.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c index 39b3a8f..a480d99 100644 --- a/arch/powerpc/kvm/mpic.c +++ b/arch/powerpc/kvm/mpic.c @@ -289,11 +289,6 @@ static inline void IRQ_resetbit(struct irq_queue *q, int n_IRQ) clear_bit(n_IRQ, q->queue); } -static inline int IRQ_testbit(struct irq_queue *q, int n_IRQ) -{ - return test_bit(n_IRQ, q->queue); -} - static void IRQ_check(struct openpic *opp, struct irq_queue *q) { int irq = -1; -- 2.3.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 2/4] kvm/ppc/mpic: drop unused IRQ_testbit 2015-03-21 6:56 ` [PATCH v4 2/4] kvm/ppc/mpic: drop unused IRQ_testbit Arseny Solokha @ 2015-03-21 14:54 ` Alexander Graf 0 siblings, 0 replies; 2+ messages in thread From: Alexander Graf @ 2015-03-21 14:54 UTC (permalink / raw) To: Arseny Solokha; +Cc: kvm, kvm-ppc, linuxppc-dev, linux-kernel On 21.03.15 07:56, Arseny Solokha wrote: > Drop unused static procedure which doesn't have callers within its > translation unit. It had been already removed independently in QEMU[1] > from the OpenPIC implementation borrowed by the kernel. > > [1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html > > v4: Fixed the comment regarding the origination of OpenPIC codebase > and CC'ed KVM mailing lists, as suggested by Alexander Graf. > > v3: In patch 4/4, do not remove fsl_mpic_primary_get_version() from > arch/powerpc/sysdev/mpic.c because the patch by Jia Hongtao > ("powerpc/85xx: workaround for chips with MSI hardware errata") makes > use of it. > > v2: Added a brief explanation to each patch description of why removed > functions are unused, as suggested by Michael Ellerman. > > Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> Thanks, applied to kvm-ppc-queue (for 4.1). Alex ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-21 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <550C0760.50903@suse.de>
2015-03-21 6:56 ` [PATCH v4 2/4] kvm/ppc/mpic: drop unused IRQ_testbit Arseny Solokha
2015-03-21 14:54 ` Alexander Graf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox