From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] KVM: nVMX: Add support for rdtscp Date: Mon, 23 Mar 2015 19:11:49 +0100 Message-ID: <55105765.2080405@web.de> References: <55102AB6.5060409@web.de> <55102EAA.4000502@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NbXFc6kIl7W8gf4jKWsGrvneruE4NSuIR" Cc: kvm , Marcelo Tosatti , Paolo Bonzini To: Bandan Das Return-path: Received: from mout.web.de ([212.227.17.11]:62415 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbbCWSL7 (ORCPT ); Mon, 23 Mar 2015 14:11:59 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NbXFc6kIl7W8gf4jKWsGrvneruE4NSuIR Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 2015-03-23 18:01, Bandan Das wrote: > Jan Kiszka writes: > ... >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -2467,6 +2467,7 @@ static void nested_vmx_setup_ctls_msrs(struct vc= pu_vmx *vmx) >> vmx->nested.nested_vmx_secondary_ctls_low =3D 0; >> vmx->nested.nested_vmx_secondary_ctls_high &=3D >> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | >> + SECONDARY_EXEC_RDTSCP | >> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE | >> SECONDARY_EXEC_APIC_REGISTER_VIRT | >> SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY | >> @@ -7510,7 +7511,7 @@ static bool nested_vmx_exit_handled(struct kvm_v= cpu *vcpu) >> return nested_cpu_has(vmcs12, CPU_BASED_INVLPG_EXITING); >> case EXIT_REASON_RDPMC: >> return nested_cpu_has(vmcs12, CPU_BASED_RDPMC_EXITING); >> - case EXIT_REASON_RDTSC: >> + case EXIT_REASON_RDTSC: case EXIT_REASON_RDTSCP: >> return nested_cpu_has(vmcs12, CPU_BASED_RDTSC_EXITING); >> case EXIT_REASON_VMCALL: case EXIT_REASON_VMCLEAR: >> case EXIT_REASON_VMLAUNCH: case EXIT_REASON_VMPTRLD: >> @@ -8517,6 +8518,9 @@ static void vmx_cpuid_update(struct kvm_vcpu *vc= pu) >> exec_control); >> } >> } >> + if (!vmx->rdtscp_enabled) >> + vmx->nested.nested_vmx_secondary_ctls_high &=3D >> + ~SECONDARY_EXEC_RDTSCP; > No need to do this if nested is not enabled ? Or just > a "if (nested)" in the prior if else loop should be enough I think. I can add this - but this is far away from being a hotpath. What would be the benefit? Thanks, Jan --NbXFc6kIl7W8gf4jKWsGrvneruE4NSuIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUQV2UACgkQitSsb3rl5xSFvACg0O2Rrql+myb3s8fQOdLNfsaq K+4AoLM70gOgJQnY7lXsGytaRh7ygCHR =pMRa -----END PGP SIGNATURE----- --NbXFc6kIl7W8gf4jKWsGrvneruE4NSuIR--