From: Paolo Bonzini <pbonzini@redhat.com>
To: Eugene Korenevsky <ekorenevsky@gmail.com>, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] KVM: remove useless check of "ret" variable prior to returning the same value
Date: Mon, 30 Mar 2015 16:57:26 +0200 [thread overview]
Message-ID: <55196456.9000203@redhat.com> (raw)
In-Reply-To: <20150328222717.GA6508@gnote>
On 28/03/2015 23:27, Eugene Korenevsky wrote:
> A trivial code cleanup. This `if` is redundant.
>
> Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
> ---
> arch/x86/kvm/emulate.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 106c015..3a494f3 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2782,10 +2782,8 @@ static int load_state_from_tss32(struct x86_emulate_ctxt *ctxt,
> return ret;
> ret = __load_segment_descriptor(ctxt, tss->gs, VCPU_SREG_GS, cpl,
> X86_TRANSFER_TASK_SWITCH, NULL);
> - if (ret != X86EMUL_CONTINUE)
> - return ret;
>
> - return X86EMUL_CONTINUE;
> + return ret;
> }
>
> static int task_switch_32(struct x86_emulate_ctxt *ctxt,
>
Applied this one for now.
Paolo
prev parent reply other threads:[~2015-03-30 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 22:27 [RFC PATCH 1/2] KVM: remove useless check of "ret" variable prior to returning the same value Eugene Korenevsky
2015-03-30 14:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55196456.9000203@redhat.com \
--to=pbonzini@redhat.com \
--cc=ekorenevsky@gmail.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox